[v7] Update BTPostalAddress Parameters
#1680
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdchow
approved these changes
Oct 16, 2025
saperi22
reviewed
Oct 17, 2025
| * Update `BTPayPalLineItem` to make all properties accessible on the initializer only vs via the dot syntax. | ||
| * BraintreeVenmo | ||
| * Update `BTVenmoLineItem` to make all properties accessible on the initializer only vs via the dot syntax. | ||
| * BraintreeCore |
There was a problem hiding this comment.
nit: do we care about alphabetical order here?
BraintreeCore before BraintreePayPal?
saperi22
approved these changes
Oct 17, 2025
jaxdesmarais
approved these changes
Oct 17, 2025
| let countryCodeAlpha2 = self["country"].asString() ?? self["countryCode"].asString() | ||
|
|
||
| return BTPostalAddress( | ||
| recipientName: recipientName, |
There was a problem hiding this comment.
not a blocker, very much a take it or leave it. For these instead of making them all stored properties we could also just this inline:
Suggested change
| recipientName: recipientName, | |
| recipientName: self["recipientName"].asString() ?? self["fullName"].asString(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
BTPostalAddressParametersChecklist
Authors